Skip to content

Comments

refactor(linter/no-process-env): restructure match to improve generated node types#14643

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/10-15-refactor_linter_no-process-env_restructure_match_to_improve_generated_node_types
Oct 15, 2025
Merged

refactor(linter/no-process-env): restructure match to improve generated node types#14643
graphite-app[bot] merged 1 commit intomainfrom
c/10-15-refactor_linter_no-process-env_restructure_match_to_improve_generated_node_types

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 15, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 15, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review October 15, 2025 21:09
Copilot AI review requested due to automatic review settings October 15, 2025 21:09
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the no_process_env linter rule to use a more idiomatic match expression with guard clauses, eliminating mutable state and improving code clarity. The refactoring reduces lines of code while maintaining the same functionality.

Key Changes:

  • Replaced mutable flag and span variables with a direct match expression that returns the span
  • Converted nested if conditions into match arm guard clauses
  • Simplified early return logic using the match's default arm

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14643 will not alter performance

Comparing c/10-15-refactor_linter_no-process-env_restructure_match_to_improve_generated_node_types (544c092) with main (58e17ae)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (544c092) during the generation of this report, so 58e17ae was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-15-refactor_linter_no-process-env_restructure_match_to_improve_generated_node_types branch from c4a3d26 to 544c092 Compare October 15, 2025 21:17
@camc314 camc314 self-assigned this Oct 15, 2025
@graphite-app graphite-app bot merged commit 544c092 into main Oct 15, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/10-15-refactor_linter_no-process-env_restructure_match_to_improve_generated_node_types branch October 15, 2025 21:21
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314